Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle dependency errors in check_imports #33622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

handle dependency errors in check_imports #33622

wants to merge 1 commit into from
+9 −2

Conversation

molbap
Copy link
Contributor

@molbap molbap commented Sep 20, 2024

What does this PR do?

Quick fix/improvement of error messages in import check. Adds a logger.error but one that's actionable for the user.
Fixes #33604

@ArthurZucker when you have time :)

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

LysandreJik
LysandreJik approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! But maybe warning is already good enough? It's the default so all users will already see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misleading ImportError error
3 participants
@molbap @HuggingFaceDocBuilderDev @LysandreJik